Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing types #301

Closed
wants to merge 0 commits into from
Closed

Added missing types #301

wants to merge 0 commits into from

Conversation

SuperDJ
Copy link
Contributor

@SuperDJ SuperDJ commented Sep 17, 2021

No description provided.

@claudiodekker
Copy link
Member

claudiodekker commented Dec 24, 2021

Hey @SuperDJ,

Thanks for this PR! As you can see above, there were some really, really weird things happening with my Git GUI, where I wasn't allowed to push updates to your fork while at the same time git somehow allowed me to force-push. In addition to that weirdness, my git copy also somehow screwed up tracking, so at some point I even pushed your master to Inertia's master(!).

In either case, I've re-created this PR in #337 and will merge that, so your contribution will still be counted. Thanks again!

claudiodekker added a commit that referenced this pull request Dec 24, 2021
* Added typings

Co-authored-by: SuperDJ <super.derkjan@gmail.com>
@SuperDJ
Copy link
Contributor Author

SuperDJ commented Jan 2, 2022

@claudiodekker I'm sorry for the problems the PR caused. I'm guessing the problems are a result of some trouble I had while merging/ fixing conflicts.

@claudiodekker
Copy link
Member

@SuperDJ No worries, I'm pretty sure my Git IDE actually screwed up and not your changes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding PHP typehint
2 participants