Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close-explicitly prop #36

Closed
choper725 opened this issue Oct 28, 2024 · 4 comments
Closed

close-explicitly prop #36

choper725 opened this issue Oct 28, 2024 · 4 comments
Labels
needs more info Incomplete issue or more info requested

Comments

@choper725
Copy link

close-explicitly prop seems not working.

@pascalbaljet
Copy link
Contributor

Can you provide some example code of how you are using it?

@pascalbaljet pascalbaljet added the needs more info Incomplete issue or more info requested label Oct 28, 2024
@choper725
Copy link
Author

sure !
just like in the docs
on calling modal-link
image

on rendered page
there is a a Modal in template with no props (tried putting it there also but still the same)

image

@Cannonb4ll
Copy link

I am indeed experiencing the exact same. Created a link exactly the same as the docs:

<template>
    <ModalLink href="/users/create" :close-explicitly="true">
        Create User
    </ModalLink>
</template>

Doesn't seem to honor this setting. I also wonder if this should be a setting on the link, or maybe on the modal component itself.

@pascalbaljet
Copy link
Contributor

Fixed in v0.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info Incomplete issue or more info requested
Projects
None yet
Development

No branches or pull requests

3 participants