Remove radix-vue dependency
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've refactored the React version, and there the UMD build went from 72.75 kB (25.25 kB gzipped) to 65.55 kB (22.77 kB gzipped). Not as drastic as the Vue refactoring, but at least it uses the same |
pascalbaljet
added a commit
that referenced
this pull request
Jan 7, 2025
This reverts commit 55b1b33.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
radix-vuefrom the Vue version and addsfocus-trap, which is a popular, well-maintained, framework-agnostic library. I want to move away fromradix-vue, as it has some advantages:DialogTitlecomponent.Still draft because I'm investigating whether we can move away from
@headlessui/reactin the React version as well. Then we could usefocus-trapthere as well and make the two versions much more consistent.