Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeighborListNeighborCache::removeRadioFromNeighborLists function does nothing #974

Closed
zqu14 opened this issue May 12, 2024 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@zqu14
Copy link

zqu14 commented May 12, 2024

Issue Description:

In the NeighborListNeighborCache::removeRadioFromNeighborLists(const IRadio *radio) function:
line 133 neighborVector.erase(it); just deletes the radio from the temporary vector declared in
line 130 Radios neighborVector = elem->neighborVector;

It seems the vector elem->neighborVector does not have any actual change after running the function. Potentially leading to the Simulation terminated with exit code: 139 error after dynamically module deletion during the simulation.

Adding elem->neighborVector = neighborVector; after line 133 will fix this issue in my own testing (in version inet-4.2.5-e0c1741924).

@levy levy self-assigned this May 14, 2024
@levy levy added the Bug label May 14, 2024
@levy levy closed this as completed in 3584bab May 14, 2024
@rhornig rhornig added this to the INET 4.6 milestone May 14, 2024
levy added a commit that referenced this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants