"Install" status to allow customers to login with peeringdb before being publicly listed as participants which "connected" status does.

[pashdown]

ISSUE TYPE

Bug Report

OS

Ubuntu 20.04.2

VERSION

define( 'APPLICATION_VERSION', '5.7.0' );
define( 'APPLICATION_VERDATE', '2020082000' );

ENVIRONMENT

# php -v
PHP 7.4.3 (cli) (built: Oct  6 2020 15:47:56) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies
# dpkg -l | grep php
ii  libapache2-mod-php7.4                7.4.3-4ubuntu2.4                  amd64        server-side, HTML-embedded scripting language (Apache 2 module)
ii  php-common                           2:75                              all          Common files for PHP packages
ii  php-composer-ca-bundle               1.2.6-1                           all          utility library to find a path to the system CA bundle
ii  php-composer-semver                  1.5.1-1                           all          utilities, version constraint parsing and validation
ii  php-composer-spdx-licenses           1.5.3-1                           all          SPDX licenses list and validation library
ii  php-composer-xdebug-handler          1.4.0-1                           all          Restarts a process without Xdebug
ii  php-ds                               1.2.9-2build1                     amd64        PHP extension providing efficient data structures for PHP 7
ii  php-igbinary                         3.1.2+2.0.8-1build1               amd64        igbinary PHP serializer
ii  php-json-schema                      5.2.9-1                           all          implementation of JSON schema
ii  php-memcache                         3.0.9~20170802.e702b5f-4build1    amd64        memcache extension module for PHP
ii  php-memcached                        3.1.4+2.2.0-1                     amd64        memcached extension module for PHP, uses libmemcached
ii  php-msgpack                          2.1.0beta1-0ubuntu2               amd64        PHP extension for interfacing with MessagePack
ii  php-psr-container                    1.0.0-2                           all          Common Container Interface (PHP FIG PSR-11)
ii  php-psr-log                          1.1.2-1                           all          common interface for logging libraries
ii  php-rrd                              2.0.1+1.1.3-7build1               amd64        PHP bindings to rrd tool system
ii  php-symfony-console                  4.3.8+dfsg-1ubuntu1               all          run tasks from the command line
ii  php-symfony-filesystem               4.3.8+dfsg-1ubuntu1               all          basic filesystem utilities
ii  php-symfony-finder                   4.3.8+dfsg-1ubuntu1               all          find files and directories
ii  php-symfony-process                  4.3.8+dfsg-1ubuntu1               all          execute commands in sub-processes
ii  php-symfony-service-contracts        1.1.8-1                           all          Generic abstractions related to writing services
ii  php-yaml                             2.0.4+1.3.2-2build1               amd64        YAML-1.1 parser and emitter for PHP
ii  php7.4                               7.4.3-4ubuntu2.4                  all          server-side, HTML-embedded scripting language (metapackage)
ii  php7.4-bcmath                        7.4.3-4ubuntu2.4                  amd64        Bcmath module for PHP
ii  php7.4-cgi                           7.4.3-4ubuntu2.4                  amd64        server-side, HTML-embedded scripting language (CGI binary)
ii  php7.4-cli                           7.4.3-4ubuntu2.4                  amd64        command-line interpreter for the PHP scripting language
ii  php7.4-common                        7.4.3-4ubuntu2.4                  amd64        documentation, examples and common module for PHP
ii  php7.4-curl                          7.4.3-4ubuntu2.4                  amd64        CURL module for PHP
ii  php7.4-fpm                           7.4.3-4ubuntu2.4                  amd64        server-side, HTML-embedded scripting language (FPM-CGI binary)
ii  php7.4-gd                            7.4.3-4ubuntu2.4                  amd64        GD module for PHP
ii  php7.4-intl                          7.4.3-4ubuntu2.4                  amd64        Internationalisation module for PHP
ii  php7.4-json                          7.4.3-4ubuntu2.4                  amd64        JSON module for PHP
ii  php7.4-mbstring                      7.4.3-4ubuntu2.4                  amd64        MBSTRING module for PHP
ii  php7.4-mysql                         7.4.3-4ubuntu2.4                  amd64        MySQL module for PHP
ii  php7.4-opcache                       7.4.3-4ubuntu2.4                  amd64        Zend OpCache module for PHP
ii  php7.4-readline                      7.4.3-4ubuntu2.4                  amd64        readline module for PHP
ii  php7.4-snmp                          7.4.3-4ubuntu2.4                  amd64        SNMP module for PHP
ii  php7.4-xml                           7.4.3-4ubuntu2.4                  amd64        DOM, SimpleXML, XML, and XSL module for PHP
ii  php7.4-zip                           7.4.3-4ubuntu2.4                  amd64        Zip module for PHP

SUMMARY

Customers need an "install" status to allow them to configure with a peeringdb login before being listed publicly with the "connected" status. Right now, "connected" is the only way to enable peeringdb logins.

STEPS TO REPRODUCE

Configure a customer status as anything other than "connected". They will not be able to login with peeringdb.

IMPORTANCE

It would be convenient in the sense that unconnected customers could be configured before being listed as participants to the rest of the customers.

[barryo]

Rather than checking if the status is other than connected we now check if the customer is suspended.

If the piece of code that is triggering your issue is what I think it is then this will allow Not Connected also.

I want to avoid added new states as that would affect lots of different areas of the codebase.