checking on an undefined snmpid, do not include those into the mrtg conf...

[fooelisa]

belts and braces barryo :)

[barryo]

Hey @fooelisa! I'm not sure the following test is the best:

if( $port->ifnameToSNMPIdentifier() )

That function just sanitises the ifname for MRTG. If I understand correctly, you have cases where there is no ifname? If so, the test would be better written as:

if( $port->getIfName() )

This would evaluate as false for null and empty string.

• Barry

[fooelisa]

You are absolutely right, they don't have a name. When I entered the interfaces I put in something called name, but on second glance it seems like this became the "name" not the "ifName" in the DB. This works for me! Thanks

[barryo]

Done.

When I entered the interfaces I put in something called name

We should really remove the code that allows you to add ports manually. This only leads to problems. Ports should be discovered and added:

• when adding the switch by SNMP discovery
• as part of a cron script that re-discovers switches routinely.

[fooelisa]

Agreed, although, It came in handy in my case for a reseller port who I entered and assigned a fake interface for. Not having an interface broke the brid config generation, which could probably use some love in this scenario as well.