Ensure string-validate uses UTF-8, not system-default #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i suspect this change is a bit more involved, i.e. like creating a requirement to specify utf8 as the input mechanism on all pages and ensuring that all the db tables are utf8 too. But yes, this is probably the way to go and this change probably needs to be rolled out across all validator calls. |
rowanthorpe
force-pushed
the
add-encoding-to-zend-string-validate
branch
from
de62e85
to
7a07a55
Compare
|
I added the same parameter to all calls to the stringLength validator. |
|
Thanks @rowanthorpe, looks good. |
barryo
added a commit
that referenced
this pull request
Jun 18, 2015
…validate Ensure string-validate uses UTF-8, not system-default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #213 for details. If this turns out to be the way to go, I will force-change this commit to add the 'UTF-8' parameter to all addValidator("stringLength") calls.