Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to use poll field instead of active field #690

Closed
wants to merge 1 commit into from

Conversation

listerr
Copy link
Contributor

@listerr listerr commented Feb 4, 2021

Seems to make more sense to use the (new?) poll field rather than active field in case there are switches active but we don't want IXPM to poll them.

Seems to make more sense to use the (new?) poll field rather than active field in case there are switches active but we don't want IXPM to poll them.
@ichilton
Copy link

@barryo Any chance we can get this merged please? :)

@barryo
Copy link
Member

barryo commented Feb 18, 2021

Hey @ichilton

I can't merge this immediately I'm afraid 😢

I need a chance to look at the original semantics of pollable and why it was added and then examine the consequences of this and #694 for ~150 other IXPs that may take a different meaning of pollable (which the UI hint suggests it's to do with the artisan job only).

Then docs + release notes may all need to be updated.

If you're happy with your updates, can you just use a locally modified version for now?

@ichilton
Copy link

@barryo Roger that! - thanks!

We are using a locally modified version for now.... just would prefer to be stock :)

@barryo barryo closed this in 87f6eba Sep 18, 2021
barryo added a commit that referenced this pull request Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants