Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move rfc1997 communities config to neighbour template #730

Merged
merged 3 commits into from
Sep 18, 2021
Merged

move rfc1997 communities config to neighbour template #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4afb0a
move rfc1997 option to neighbor template
listerr Aug 13, 2021
0bc3afc
move rfc1997 passthrough to neighbor template
listerr Aug 13, 2021
7213993
Complete PR & fix big (endif not copied over)
barryo Sep 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/travis-ci/known-good/ci-apiv4-b2-rs1-lan1-ipv6.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,8 @@ template bgp tb_rsclient {
# (RPKI is /really/ quick)
connect delay time 30;

interpret communities off; # enable rfc1997 well-known community pass through

ipv6 {
export all;
missing lladdr ignore;
Expand Down Expand Up @@ -490,7 +492,6 @@ protocol bgp pb_0001_as1213 from tb_rsclient {
table t_0001_as1213;
export filter f_export_as1213;
};
interpret communities off; # enable rfc1997 well-known community pass through
password "N7rX2SdfbRsyBLTm";
}

Expand Down Expand Up @@ -640,7 +641,6 @@ protocol bgp pb_0006_as25441 from tb_rsclient {
table t_0006_as25441;
export filter f_export_as25441;
};
interpret communities off; # enable rfc1997 well-known community pass through
password "X8Ks9QnbER9cyzU3";
}

Expand Down
3 changes: 3 additions & 0 deletions resources/views/api/v4/router/server/bird2/neighbor-template.foil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
# (RPKI is /really/ quick)
connect delay time 30;

<?php if( $t->router->rfc1997_passthru ): ?> interpret communities off; # enable rfc1997 well-known community pass through
<?php endif; ?>

<?= $t->ipproto ?> {
export all;
<?php if( $t->router->protocol == 6 ): ?>
Expand Down
2 changes: 0 additions & 2 deletions resources/views/api/v4/router/server/bird2/neighbors.foil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,6 @@
table t_<?= $int['fvliid'] ?>_as<?= $int['autsys'] ?>;
export filter f_export_as<?= $int['autsys'] ?>;
};
<?php if( $t->router->rfc1997_passthru ): ?> interpret communities off; # enable rfc1997 well-known community pass through
<?php endif; ?>
<?php if( $int['bgpmd5secret'] && !$t->router->skip_md5 ): ?>password "<?= $int['bgpmd5secret'] ?>";<?php endif; ?>

}
Expand Down