Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing vlan id #773

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fixing vlan id #773

merged 1 commit into from
Jan 26, 2022

Conversation

AleksBelytskyi
Copy link
Contributor

variable $vlanid is assigned incorrectly, because of it the netmask of IP addresses is empty

[BF] Summary of fix - fixes [inex|islandbridgenetworks]/IXP-Manager#x

[NF] New feature summary - closes [inex|islandbridgenetworks]/IXP-Manager#x

Longer description

In addition to the above, I have:

  • [ x] ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • [ x] ensured appropriate checks against user privilege / resources accessed
  • [ x] API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

variable $vlanid is assigned incorrectly, beacuse of it the netmask of IP addresses is emty
@barryo barryo merged commit 8bc65f9 into inex:master Jan 26, 2022
@AleksBelytskyi AleksBelytskyi deleted the patch-1 branch January 27, 2022 18:05
barryo pushed a commit that referenced this pull request Jul 4, 2022
variable $vlanid is assigned incorrectly, beacuse of it the netmask of IP addresses is emty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants