[cmake] Add windows resource file for application icon and metadata #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

IAmNotHanni merged 1 commit into main from hanni/windows_ressource_file

Oct 9, 2025

Member

IAmNotHanni commented May 3, 2021 •

edited

Loading

Closes #382
Closes #420

grafik

TODO

Rework this pull request after [cmake] Use CMake to configure engine and app metadata instead of toml file #329 is merged.
Switch language to English
Do we really need resource.hpp?
Add Git SHA to application's metadata
Ignore resource file in CMake on Linux to fix build
Ask @IceflowRE for help

IAmNotHanni added the cat:enhancement label

IAmNotHanni self-assigned this

IceflowRE reviewed

View reviewed changes

platform/windows/win_resource_file.rc.in Outdated Show resolved Hide resolved

IceflowRE reviewed

View reviewed changes

example/CMakeLists.txt Outdated Show resolved Hide resolved

IceflowRE reviewed

View reviewed changes

platform/windows/CMakeLists.txt Outdated Show resolved Hide resolved

IceflowRE reviewed

View reviewed changes

platform/windows/resource.hpp.in Outdated Show resolved Hide resolved

IceflowRE reviewed

View reviewed changes

platform/windows/win_resource_file.rc.in Outdated Show resolved Hide resolved

IceflowRE reviewed

View reviewed changes

Member

IceflowRE left a comment

In general theres no need to configure the .rc file, as you just can include our meta.hpp with all the data and use it there.

IAmNotHanni added the org:on hold label

IAmNotHanni force-pushed the hanni/windows_ressource_file branch from 7090fac to 5985343 Compare

July 19, 2021 19:10

IAmNotHanni commented

View reviewed changes

example/CMakeLists.txt Outdated Show resolved Hide resolved

IAmNotHanni marked this pull request as ready for review

July 19, 2021 22:08

IAmNotHanni requested review from IceflowRE and yeetari

July 19, 2021 22:08

IAmNotHanni removed the org:on hold label

Member Author

IAmNotHanni commented Jul 19, 2021

Alright I'm ready for review 👍

Member Author

IAmNotHanni commented Jul 21, 2021

I will include the following fix in meta.hpp.in

#ifndef NDEBUG
constexpr const char *BUILD_TYPE = "Debug";
#else
constexpr const char *BUILD_TYPE = "Release";
#endif

This will also fix #420

IceflowRE requested changes

View reviewed changes

include/inexor/vulkan-renderer/meta.hpp.in Outdated Show resolved Hide resolved

Member

IceflowRE commented Jul 22, 2021

Will review the rest later.

IAmNotHanni force-pushed the hanni/windows_ressource_file branch from 8fb8acf to ffd6495 Compare

July 28, 2021 17:53

Member Author

IAmNotHanni commented Jul 28, 2021

I rebased onto master.

IAmNotHanni force-pushed the hanni/windows_ressource_file branch from ffd6495 to 0458ae4 Compare

July 30, 2021 19:37

This comment was marked as resolved.

Sign in to view

IceflowRE previously requested changes

View reviewed changes

example/CMakeLists.txt Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

IAmNotHanni added the prio:low label

IAmNotHanni marked this pull request as draft

November 28, 2021 12:10

IAmNotHanni force-pushed the hanni/windows_ressource_file branch from 0458ae4 to dc37829 Compare

October 7, 2025 10:32


          [meta] Add Windows resource file

861b7aa

IAmNotHanni force-pushed the hanni/windows_ressource_file branch from 94e5281 to 861b7aa Compare

October 7, 2025 12:47

IAmNotHanni marked this pull request as ready for review

October 7, 2025 12:48

IAmNotHanni requested a review from IceflowRE

October 7, 2025 12:48

IAmNotHanni dismissed IceflowRE’s stale review

October 7, 2025 12:49

Outdated. Please re-review

Member Author

IAmNotHanni commented Oct 7, 2025 •

edited

Loading

Alright, ready for review again.
This also works for tests and benchmarks :)
It also works with the Windows builds from CI correctly, nice!

Member Author

IAmNotHanni commented Oct 9, 2025

Ah I think I can just merge this. All previous issues have been resolved.
I will work on the wiki update next.

IAmNotHanni merged commit 6b11b2c into main

16 checks passed

IAmNotHanni deleted the hanni/windows_ressource_file branch

October 9, 2025 16:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:enhancement prio:low