Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fi 1977 slow #64

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Fi 1977 slow #64

merged 6 commits into from
Aug 1, 2023

Conversation

rpassas
Copy link
Contributor

@rpassas rpassas commented Jul 25, 2023

Summary

Set temporary routes while the validator loads. These are unmapped and proper routes are set once the IGs are loaded and the validator is instantiated.

@rpassas rpassas requested a review from dehall July 25, 2023 20:49
dehall
dehall requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@dehall dehall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general approach works but we need to figure out the right value that the routes should return during the loading period

src/main/java/org/mitre/inferno/rest/Endpoints.java Outdated Show resolved Hide resolved
src/main/java/org/mitre/inferno/rest/Endpoints.java Outdated Show resolved Hide resolved
@rpassas rpassas requested a review from dehall July 27, 2023 20:26
@dehall dehall mentioned this pull request Jul 31, 2023
Merged
@dehall dehall merged commit 33b49c9 into master Aug 1, 2023
@dehall dehall deleted the fi-1977-slow branch August 1, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jammjammjamm Jammjammjamm Jammjammjamm left review comments

@dehall dehall dehall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpassas @dehall @Jammjammjamm