-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2038: Prevent modal close on edit #383
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 77.09% 77.10% +0.01%
==========================================
Files 213 213
Lines 10476 10510 +34
Branches 968 969 +1
==========================================
+ Hits 8076 8104 +28
- Misses 1834 1839 +5
- Partials 566 567 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
* add codecov * turn codecov on * modify backend target * add patch coverage --------- Co-authored-by: Alyssa Wang <awang@mitre.org>
Works as you described, and I can see how this would save users from a potentially bad misclick, though it does seem weird to me that once you edit the form you can't click outside the modal without any obvious reason why it suddenly becomes unclickable. It took me a sec to figure out how to close the modal after editing and it felt like a bug... I looked for an 'X' on the top right but nothing there, then scanned down to the find the 'Cancel' button on the bottom. I don't know how much this matters. Could @mrnosal take a look at this user experience and either approve or make suggestions? I think it makes sense for him to make the call here. As long as this is a net improvement I'm good with merging it, just want to check w/mike that we aren't replacing one issue with another equal issue |
It would be pretty easy to add an X button so happy to do that if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behavior when edits have been made is consistent for Field, JSON and YAML inputs. Close box added with tooltip to warn of data loss.
Summary
While editing inputs in the dialog, clicking outside the dialog should no longer automatically close the modal.
Testing Guidance