Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2077: Improve colors and contrasts for a11y #392

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Addresses the following issues:

  1. Low contrast between red errors and orange focus on input fields: input color changed from primary to secondary (blue).
Screenshot 2023-09-11 at 6 24 52 PM
  1. Disabled buttons with the contained style have color contrast issues: font weight increased to mitigate this issue. I don't think colors can be changed much without compromising the disabled status indicator.

  2. Hover state of the buttons has too low of a visual change and should be made more clearly visible: changed the color on text style buttons to improve contrast between the button and the background

Screenshot 2023-09-11 at 6 28 51 PM
  1. The green 'pass' and red 'fail' icons' visual contrast for users with protanopia and deuteranopia is extremely low: increased the saturation on the red color to improve contrast (red: rgb(211, 47, 47), green: rgb(76, 175, 80))

  2. Tabs in the Test results are shown in normal weight font while the tabs in the configuration messages are in a bold font, which makes the text appear darker almost to the point of having the same visual contrast as the active tabs color: after trying a number of different colors, they all seem to have this issue. Since there is a bottom border than indicates active status, I think this is OK to leave as is.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +17.40% 🎉

Comparison is base (3b09428) 76.95% compared to head (cffb61a) 94.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #392       +/-   ##
===========================================
+ Coverage   76.95%   94.36%   +17.40%     
===========================================
  Files         213      116       -97     
  Lines       10597     3140     -7457     
  Branches      978      393      -585     
===========================================
- Hits         8155     2963     -5192     
+ Misses       1873      177     -1696     
+ Partials      569        0      -569     
Flag Coverage Δ
backend 94.36% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 97 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loaded it up and the updates to the form colors and the pass/fail colors look good to me.

@AlyssaWang AlyssaWang merged commit 44da696 into main Sep 12, 2023
8 checks passed
@AlyssaWang AlyssaWang deleted the FI-2077-colors branch September 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants