FI-2330: Request tags #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 77.02% 77.10% +0.08%
==========================================
Files 217 218 +1
Lines 10828 10872 +44
Branches 1013 1018 +5
==========================================
+ Hits 8340 8383 +43
- Misses 1910 1911 +1
Partials 578 578
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tstrass
requested changes
Dec 1, 2023
tstrass
approved these changes
Dec 1, 2023
Jammjammjamm
force-pushed
the
fi-2330-request-tags
branch
from
cbe61a7
to
ff68fc6
Compare
Jammjammjamm
force-pushed
the
fi-2330-request-tags
branch
from
ff68fc6
to
861555c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds the ability to assign arbitrary tags to requests, and then find requests with particular tags.
Testing Guidance
This branch includes changes to the db, so be sure to run
bundle exec inferno migrate.There are unit tests as well as an example in the demo suite you can mess around with.