Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2688: Migrate template to HL7 validator wrapper #492

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

dehall
Copy link
Contributor

@dehall dehall commented May 21, 2024

Summary

Update the "inferno new" template to use the HL7 validator wrapper, as in all of our test kits. One notable difference here is the inferno validator-wrapper and validator UI are not commented out, they are left as-is, so this is mostly just addition other than changing the test suite validator block to fhir_resource_validator.

Corresponding changes to the docs are at: inferno-framework/inferno-framework.github.io#32

Testing Guidance

Re-generate the template with bundle exec inferno new inferno-template --author "Inferno Template" and it will be in ./inferno-template
Sample patient tests should pass, the validator UI should still work as well at http://localhost/validator/ .
YAML to run against reference server:

- name: url
  title: FHIR Server Base Url
  type: text
  value: https://inferno.healthit.gov/reference-server/r4
- name: credentials
  optional: true
  title: OAuth Credentials
  type: oauth_credentials
  value:
    access_token: SAMPLE_TOKEN
    refresh_token: ''
    expires_in: ''
    client_id: ''
    client_secret: ''
    token_url: ''
- name: patient_id
  title: Patient ID
  type: text
  value: '85'

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (85183c0) to head (47d6bc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   80.23%   80.21%   -0.02%     
==========================================
  Files         240      240              
  Lines       11896    11900       +4     
  Branches     1163     1163              
==========================================
+ Hits         9545     9546       +1     
- Misses       1691     1694       +3     
  Partials      660      660              
Flag Coverage Δ
backend 93.63% <ø> (-0.08%) ⬇️
frontend 74.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template's unit tests also need to be updated.

@dehall dehall force-pushed the fi-2688-hl7-validator-template branch from 178decb to 47d6bc0 Compare June 3, 2024 13:25
@dehall dehall requested a review from Jammjammjamm June 3, 2024 13:29
@dehall dehall merged commit a10dfb0 into main Jun 3, 2024
10 checks passed
@dehall dehall deleted the fi-2688-hl7-validator-template branch June 3, 2024 13:53
@rpassas rpassas mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants