Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2753: Add hover effect to request details #495

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Change color of code block header on hover in the request details modal.

Testing Guidance

Check that hover effect appears, header should maintain effect while accordion is open.

Q: Should test list items also have this effect?

@AlyssaWang AlyssaWang requested review from arscan and mrnosal May 24, 2024 15:18
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.24%. Comparing base (2dd6da7) to head (db19605).

Files Patch % Lines
...nt/src/components/RequestDetailModal/CodeBlock.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   80.22%   80.24%   +0.01%     
==========================================
  Files         240      240              
  Lines       11881    11893      +12     
  Branches     1161     1162       +1     
==========================================
+ Hits         9532     9543      +11     
  Misses       1691     1691              
- Partials      658      659       +1     
Flag Coverage Δ
backend 93.70% <ø> (ø)
frontend 74.22% <93.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrnosal mrnosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover effect works as expected - code changes look good.

@AlyssaWang AlyssaWang merged commit 6b88693 into main May 29, 2024
10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2753-request-hover branch May 29, 2024 18:01
@rpassas rpassas mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants