Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2765: Automatically run migrations #496

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

Automatically run migrations when using inferno start or inferno console.

Testing Guidance

Delete data/inferno_development.db, then run bin/inferno start. The migrations should run and inferno should start.

@Jammjammjamm Jammjammjamm requested a review from arscan May 28, 2024 14:36
@Jammjammjamm Jammjammjamm self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (a4e874c) to head (c9e290b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files         240      240           
  Lines       11881    11881           
  Branches     1161     1161           
=======================================
  Hits         9532     9532           
  Misses       1691     1691           
  Partials      658      658           
Flag Coverage Δ
backend 93.70% <ø> (ø)
frontend 74.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arscan
Copy link
Contributor

arscan commented May 28, 2024

Should we change the README to not include the migrate step? Same for other documentation? Unsure if we consider it a best practice to manually do the step or if we should just consider it a exception-case type command now.

@Jammjammjamm
Copy link
Collaborator Author

I think it should at least stay here in the developer instructions. It logs at a lower level, so more information is displayed when running the migrations by themselves.

@Jammjammjamm Jammjammjamm merged commit 2dd6da7 into main May 28, 2024
10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-2765-auto-migrate branch May 28, 2024 17:17
@rpassas rpassas mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants