Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2734: Fix single test run error #500

Merged
merged 3 commits into from
Jun 3, 2024
Merged

FI-2734: Fix single test run error #500

merged 3 commits into from
Jun 3, 2024

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Running a single test was broken and should now be fixed. This was caused by a combination of passing the incorrect Runnable object and a rendering bug on the inputs modal.

Testing Guidance

Try running single tests and test groups and make sure there are no errors. Also try navigating from group to group while tests are running; rendered pages and the progress bar should all appear correctly.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 80.11%. Comparing base (a10dfb0) to head (4942ebf).

Files Patch % Lines
client/src/components/TestSuite/TestSession.tsx 31.57% 11 Missing and 2 partials ⚠️
client/src/components/InputsModal/InputsModal.tsx 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   80.21%   80.11%   -0.11%     
==========================================
  Files         240      240              
  Lines       11900    11909       +9     
  Branches     1163     1166       +3     
==========================================
- Hits         9546     9541       -5     
- Misses       1694     1705      +11     
- Partials      660      663       +3     
Flag Coverage Δ
backend 93.63% <ø> (ø)
frontend 74.07% <40.74%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlyssaWang AlyssaWang merged commit c3eb7c2 into main Jun 3, 2024
9 of 10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2734-single-test branch June 3, 2024 18:37
@rpassas rpassas mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants