-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ReactMarkdown in Inputs/Outputs #504
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
- Coverage 79.47% 79.46% -0.01%
==========================================
Files 242 242
Lines 12080 12078 -2
Branches 1185 1185
==========================================
- Hits 9600 9598 -2
Misses 1815 1815
Partials 665 665
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0fd69af
to
d7c2dff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would probably also double check the other instances of ReactMarkdown to see if they're also running into this issue and address accordingly but this is mergeable now.
LGTM
Thanks. A newbie question; I assigned three reviewers, should all of the three approve, or one approval out of three is good to merge? |
One is usually sufficient unless there is a reason to want approval from specific people! |
Summary
Original issue: inferno-framework/bulk-data-test-kit#24
Problem: contents in Inputs and Outputs are converted to markdown. Though it's useful for styles, can cause problems when strings like URLs are broken by that.
Fix: removed React Markdown in the HTML.
Testing Guidance
~~SAMPLE_TOKEN~~
)Consideration
react-markdown
is being used as below. Further investigation needs to figure out whether markdown is being used unnecessarily.