-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2857: Add auth input option #514
Conversation
… FI-2857-auth-input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For auth and access mode : the
auth_type
value is not sent to the backend. - Auth mode: the
auth_type
dropdown does not behave properly when switching values. On change, the auth fields should also change to match the selected auth type. - Access Mode:
- I think we also want to have the auth type dropdown here.
- When
refresh_token
is present, all types display more fields than needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… FI-2857-auth-input
… FI-2857-auth-input
Ready for rereview. My main remaining question is concerning some values and how to normalize the capitalization:
I've capitalized everything for now as I believe that's how they are in some of the non-dev tests but let me know if this should/will change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend Services Auth Mode input should not show:
- Proof Key for Code Exchange (PKCE)
- PKCE Code Challenge Method
- Authorization Request Method
Backend Services Access Mode input should not show Refresh Token.
Summary
Creates auth info inputs for both auth and access modes.
Testing Guidance
Confirm that inputs work with the AuthInfo test suite. Check new dropdown and single checkbox input options for behavior issues.