FI-2910: Host JWKS for Client Assertion #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Co-authored-by: Stephen MacVicar <Jammjammjamm@users.noreply.github.com>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Co-authored-by: Stephen MacVicar <Jammjammjamm@users.noreply.github.com>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
lib/inferno/dsl/auth_info.rb
Outdated
| @@ -270,7 +270,8 @@ def auth_jwt_header | |||
| { | |||
| 'alg' => encryption_algorithm, | |||
| 'kid' => private_key['kid'], | |||
| 'typ' => 'JWT' | |||
| 'typ' => 'JWT', | |||
| 'jku' => "#{Inferno::Application['base_url']}/jwks.json" | |||
There was a problem hiding this comment.
Let's add the jwks url as an inferno application property so that no one ever has to build it, like how we do for base url: https://github.com/inferno-framework/inferno-core/blob/main/lib/inferno/config/application.rb#L23
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
…rno-core into fi-2910-host-jwks
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
…rno-core into fi-2910-host-jwks
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
vanessuniq
changed the base branch from
fi-2865-fhir-client-auth-info-refresh
to
main
Jammjammjamm
approved these changes
Jul 22, 2024
vanessuniq
changed the base branch from
main
to
fi-2865-fhir-client-auth-info-refresh
vanessuniq
changed the base branch from
fi-2865-fhir-client-auth-info-refresh
to
main
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 79.64% 79.69% +0.04%
==========================================
Files 243 243
Lines 12174 12178 +4
Branches 1204 1205 +1
==========================================
+ Hits 9696 9705 +9
+ Misses 1813 1808 -5
Partials 665 665
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch hosts the JWKS used for signing client assertions in core, and populate the
jkufield in the client assertion with the JWKS url.Testing Guidance