Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why remove CSSProperties in 8.0? #1604

Closed
tolg opened this issue Aug 16, 2022 · 3 comments
Closed

Why remove CSSProperties in 8.0? #1604

tolg opened this issue Aug 16, 2022 · 3 comments

Comments

@tolg
Copy link

tolg commented Aug 16, 2022

CSSProperties is a vary handy type when coding some HTML element style, but I found that inferno 8.0 changed the style property's type to any. What's the consideration of this changing?
@Havunen
Copy link
Member

Havunen commented Aug 16, 2022

Yeah, I'm planning to add them back, but need to think how to get it done nicely.
React.CssProperties is based on this package: https://github.com/frenic/csstype
which types them like textAlign: 'middle', in inferno that would be: text-align: 'middle', or it could be given as style string

@Havunen
Copy link
Member

Havunen commented Aug 17, 2022

Oh it seems it supports types by hyphen https://github.com/frenic/csstype 🤩

Havunen pushed a commit that referenced this issue Aug 18, 2022
Added more JSX element types, fixed style property typing, adds back …
ded256a 
…csstype, Github #1604
@Havunen
Copy link
Member

Havunen commented Aug 18, 2022

This will be fixed in 8.0.3

@Havunen Havunen closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Havunen @tolg