Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup inferno animation #1575

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Cleanup inferno animation #1575

merged 6 commits into from
Oct 22, 2021

Conversation

jhsware
Copy link
Contributor

@jhsware jhsware commented Oct 21, 2021

Objective

All fixes relate to inferno-animation.

  • Fixed a bug that prevented (optional) animation on width and height.
  • Improved comments in code slightly.
  • Added code example in README on how to implement bootstrap style animations used in modals etc.
  • Added a demo of animating a child component when mounting/unmounting parent. Useful for nice onboarding UX.

Closes Issue

Verified some UX use cases I have in real projects.

@coveralls
Copy link
Collaborator

coveralls commented Oct 21, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 93.093% when pulling df75747 on jhsware:cleanup-inferno-animation into 4e27947 on infernojs:master.

Havunen
Havunen approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@Havunen Havunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Havunen Havunen merged commit e590184 into infernojs:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Havunen Havunen Havunen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhsware @coveralls @Havunen