Rework development mode related inferno warnings #1573 #1582 #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1100i
commented
Feb 2, 2024
Havunen
reviewed
Feb 2, 2024
* adds checking of variable `SKIP_INFERNO_WARNINGS` to skip warnings in non-production mode * `SKIP_INFERNO_WARNINGS` can be also declared globally for browser functionality, or just defined on the process.env in case of node * FYI: JEST related warning skip about development mode was removed with 2ed75dc when fixing #1582, only the skipping of minified code warning was in place
|
Re-Opening to wake up TravisCI |
|
seems like coveralls is timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds checking of variable
SKIP_INFERNO_WARNINGSto skip warnings in non-production modeSKIP_INFERNO_WARNINGScan be also declared globally for browser functionality, or just defined on the process.env in case of nodeFYI: JEST related warning skip about development mode was removed with 2ed75dc when fixing PR1581 breaks demos and probably a lot of other things #1582, only the skipping of minified code warning was in place
Lemme know if you have ideas about testing this modification!