Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #1936

Merged
merged 12 commits into from
Sep 29, 2024
Merged

Refactor code #1936

merged 12 commits into from
Sep 29, 2024

Conversation

JinHai-CN
Copy link
Contributor

What problem does this PR solve?

  • Version info is printed after welcome message.
  • Wrong config file path will not use default config, an error is issued.

Type of change

  • Refactoring

@JinHai-CN
Fix error config file won't issue error
5034c22 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
Fix compile error
6a0ccae 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
Remove unused comments
dddae93 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
refactor: use virtual storage to replace local filesystem
20df43f 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
refactor: use virtual storage to replace local filesystem, 1
ec75ec8 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
refactor: use virtual storage to replace local filesystem, 2
a048468 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
refactor: use virtual storage to replace local filesystem, 3
eb8b565 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN JinHai-CN added the ci PR can be test label Sep 28, 2024
@JinHai-CN
Merge remote-tracking branch 'upstream/main' into fix288
a07fdb7
@JinHai-CN
Add seek functions
3aeff57 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
Fix UT
1e7e3a9 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
Fix UT
b40c2b0 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN
Remove unused import
b21b71e 
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
@JinHai-CN JinHai-CN merged commit 377ddcd into infiniflow:main Sep 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci PR can be test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JinHai-CN