Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make infinity work under linux/arm64 #2082

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

yingfeng
Copy link
Member

What problem does this PR solve?

Issue link:#1720

Type of change

  • New Feature (non-breaking change which adds functionality)

@yingfeng yingfeng added the ci PR can be test label Oct 21, 2024
@yingfeng yingfeng requested review from small-turtle-1 and yangzq50 and removed request for small-turtle-1 October 21, 2024 09:30
Copy link
Contributor

@small-turtle-1 small-turtle-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yingfeng yingfeng merged commit c693828 into infiniflow:main Oct 21, 2024
4 checks passed
@yingfeng
Copy link
Member Author

There's one thing to be mentioned that, third_party/thrift could not be compiled under Linux/Aarch64 due to the

  int rv = strerror_r(errno_copy, b_errbuf, sizeof(b_errbuf));

https://github.com/infiniflow/infinity/blob/main/third_party/thrift/lib/cpp/src/thrift/TOutput.cpp#L118

Because STRERROR_R_CHAR_P check failed during cmake process.
The quick fix is to manually enable STRERROR_R_CHAR_P in CMakeCache.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci PR can be test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants