-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Dynamically create the service_conf.yaml file by replacing environment variables from .env #3322
Comments
Waiting for that good PR... |
Just submitted the PR. Also changed the documentation accordingly. I decided to name the template file And I was only able to change the EN version of the documentation ;-) |
@KevinHuSh by the way, the reason why I needed this feature, is the fact that I want to add RAGFlow to the Platys Modern Data Platform stack, a flexible way to generate |
…t variables from .env (#3341) ### What problem does this PR solve? This pull request implements the feature mentioned in #3322. Instead of manually having to edit the `service_conf.yaml` file when changes have been made to `.env` and mapping it into the docker container at runtime, a template file is used and the values replaced by the environment variables from the `.env` file when the container is started. ### Type of change - [X] New Feature (non-breaking change which adds functionality) --------- Co-authored-by: Kevin Hu <kevinhu.sh@gmail.com> Co-authored-by: Zhichang Yu <yuzhichang@gmail.com>
@gschmutz |
Hi @yuzhichang just saw the changes in the |
Done. |
Is there an existing issue for the same feature request?
Is your feature request related to a problem?
Manually editing the
service_conf.yaml
file and keeping it in sync with the.env
file could be avoided by dynamically replacing the values by the environment variables.Describe the feature you'd like
Instead of manually having to edit the
service_conf.yaml
file and mapping it into the docker container at runtime, a template file could be used and the values replaced by the environment variables from the.env
file.This template file needs to be copied into the docker image so that it is available for the replacement.
The replacement of the env vars would be done in the
entrypoint.sh
file and the mapping of theservice_conf.yaml
file in thedocker-compose.yaml
is no longer necessary.Describe implementation you've considered
see description above.
I have it working locally and could submit a pull request with the changes.
Documentation, adoption, use case
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: