Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme switch support #3568

Merged
merged 80 commits into from
Dec 10, 2024
Merged

Theme switch support #3568

merged 80 commits into from
Dec 10, 2024

Conversation

isthaison
Copy link
Contributor

@isthaison isthaison commented Nov 21, 2024 •
edited by yingfeng
Loading

What problem does this PR solve?

  • New Feature (non-breaking change which adds functionality)

@yingfeng yingfeng requested a review from cike8899 November 21, 2024 15:17
@yingfeng yingfeng added the ci Continue Integration label Nov 22, 2024
@isthaison
Copy link
Contributor Author

I have added theme feature , and fixed error when api return no chunk in Page searching, Hope it will help your project
Recording2024-11-22113727-ezgif com-video-to-gif-converter

@cike8899
Copy link
Contributor

There are many display issues in night mode, such as

image

@isthaison
Copy link
Contributor Author

image
I 've update for flow. @cike8899 , please check again

@isthaison
Copy link
Contributor Author

hi @cike8899 . In this project css declaration is separate, it is difficult to check all ui components. Can you check again, thank you

@cike8899
Copy link
Contributor

image
image
image
image
image
image
image
image

@isthaison
Copy link
Contributor Author

@cike8899 please check again

@cike8899
Copy link
Contributor

cike8899 commented Dec 4, 2024

image
image

@isthaison
Copy link
Contributor Author

@cike8899 @yingfeng , please check again

yingfeng
yingfeng requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@yingfeng yingfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please guarantee it can pass the CI before it could be merged.
Why you downgrade duckduckgo-search in poetry?

@isthaison
Copy link
Contributor Author

image
with current version duckgo has rate limited problem. this is related issue
relate Is: crewAIInc/crewAI#136

@yingfeng
Copy link
Member

yingfeng commented Dec 9, 2024

If you want to modify poetry, you should lock at first. Please see the error information during docker build in CI

@isthaison
Copy link
Contributor Author

If so I will split it into 2 requests. That will be more convenient.

@isthaison isthaison requested a review from yingfeng December 9, 2024 11:15
@KevinHuSh KevinHuSh merged commit d5a322a into infiniflow:main Dec 10, 2024
2 checks passed
@sd109 sd109 mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingfeng yingfeng yingfeng approved these changes

@cike8899 cike8899 Awaiting requested review from cike8899

Assignees
No one assigned
Labels
ci Continue Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isthaison @cike8899 @JinHai-CN @yingfeng @KevinHuSh