Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top_k for create_chat and update_chat api #4294

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

Feiue
Copy link
Contributor

@Feiue Feiue commented Dec 30, 2024

What problem does this PR solve?

Add top_k for create_chat and update_chat api #4157

Type of change

  • New Feature (non-breaking change which adds functionality)

@Feiue Feiue added the ci Continue Integration label Dec 30, 2024
@KevinHuSh KevinHuSh merged commit b52b0f6 into infiniflow:main Dec 30, 2024
3 checks passed
@panzi
Copy link
Contributor

panzi commented Feb 11, 2025

Great!

It doesn't seem to be returned with the Chat.Prompt object, though:

Error: 'Base' object has no attribute 'top_k'
Traceback (most recent call last):
  File "/app/src/ai/index_manager.py", line 701, in create_ragflow_store
    assistant.prompt.top_k != RAGFLOW_TOP_K:
    ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Base' object has no attribute 'top_k'

I guess that's a separate bug/feature request.

@panzi
Copy link
Contributor

panzi commented Feb 11, 2025

New issue: #4886

@KevinHuSh
Copy link
Collaborator

I don't get it.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continue Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants