Fix macOS startup #4658
Open
Fix macOS startup #4658
+79
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for `graspologic-native` (v1.2.3) Signed-off-by: Samuel Giffard <samuel.giffard@mytomorrows.com>
It now uses `uname -m` to properly determine whether to install msodbcsql17 or msodbcsql18. Signed-off-by: Samuel Giffard <samuel.giffard@mytomorrows.com>
It now includes a one-line install and start command line. Instead of using a pre-built image, it uses `../Dockerfile`, which now works on Apple M-chips. Signed-off-by: Samuel Giffard <samuel.giffard@mytomorrows.com>
|
Appreciation! |
Signed-off-by: Samuel Giffard <samuel.giffard@mytomorrows.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#4319
This pull request includes several changes to improve the Docker setup and documentation for the project. The most important changes include updating the Dockerfile to support modern versions of Rust, adding a new Docker Compose configuration for macOS, and updating the build instructions in the documentation.
Improvements to Docker setup:
Dockerfile: Added installation steps for a modern version of Rust and updated the logic for installing the correct ODBC driver based on the architecture.docker/docker-compose-macos.yml: Added a new Docker Compose configuration file specifically for macOS, including service dependencies, environment variables, and volume mappings.Updates to documentation:
docs/guides/develop/build_docker_image.mdx: Updated the build instructions to use the new Docker Compose configuration for macOS instead of the previous Docker build command.Type of change