fix: metrics collection after cluster recovery from unavailability (#37)

* fix: issue where collection tasks were not updated after metadata changes

* fix: the issue with cluster health status reporting success incorrectly

modules/elastic/metadata.go

@@ -85,16 +85,18 @@ func (module *ElasticModule) clusterHealthCheck(clusterID string, force bool) {
 				}
 				log.Tracef("cluster [%v] health [%v] updated", clusterID, metadata.Health)
 			}
-			metadata.ReportSuccess()
 			changes, err := util.DiffTwoObject(metadata.Health, health)
 			if err != nil {
 				log.Errorf("diff cluster health error: %v", err)
 			}
 			if len(changes) > 0 {
 				//copy metadata and update metadata safely
 				newMeta := *metadata
+				newMeta.ReportSuccess()
 				newMeta.Health = health
 				elastic.SetMetadata(metadata.Config.ID, &newMeta)
+			}else{
+				metadata.ReportSuccess()
 			}
 		}
 	}

modules/metrics/metrics.go

@@ -107,8 +107,17 @@ func (module *MetricsModule) Setup() {
 	elastic2.RegisterMetadataChangeEvent(func(meta, oldMeta *elastic2.ElasticsearchMetadata, action elastic2.EventAction) {
 		if action == elastic2.EventActionUpdate && oldMeta != nil {
 			//skip if no monitor config changed
+			hasChanged := false
 			changelog, _ := util.DiffTwoObject(oldMeta.Config.MonitorConfigs, meta.Config.MonitorConfigs)
-			if len(changelog) == 0 {
+			if len(changelog) > 0 {
+				hasChanged = true
+			}else if meta != nil {
+				// check other conditions
+				hasChanged = meta.IsAvailable() != oldMeta.IsAvailable() ||
+					meta.Config.Enabled != oldMeta.Config.Enabled ||
+					meta.Config.Monitored != oldMeta.Config.Monitored
+			}
+			if !hasChanged {
 				return
 			}
 		}