Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing the logic of collecting metric per each node #26

Merged
merged 5 commits into from
Dec 24, 2024
Merged

fix: removing the logic of collecting metric per each node #26

merged 5 commits into from
Dec 24, 2024

Conversation

silenceqi
Copy link
Contributor

@silenceqi silenceqi commented Dec 24, 2024 •
edited
Loading

What does this PR do

removing the logic of collecting metric per each node

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@silenceqi silenceqi requested review from medcl and luohoufu December 24, 2024 03:26
luohoufu
luohoufu approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medcl medcl merged commit 0b24918 into main Dec 24, 2024
2 checks passed
@medcl medcl deleted the fix-metric branch December 24, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohoufu luohoufu luohoufu approved these changes

@medcl medcl medcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silenceqi @medcl @luohoufu