Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create file before put content to it #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: create file before put content to it #71

wants to merge 2 commits into from

Conversation

luohoufu
Copy link
Contributor

@luohoufu luohoufu commented Jan 23, 2025 •
edited
Loading

What does this PR do

This pull request includes changes to the SaveConfigStr function in the modules/configs/config/config.go file to improve error handling and ensure the configuration directory exists before saving the configuration file.

Improvements to error handling and directory creation:

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@luohoufu luohoufu requested review from medcl and silenceqi January 23, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silenceqi silenceqi silenceqi approved these changes

@medcl medcl Awaiting requested review from medcl

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luohoufu @silenceqi @luohf-infinilabs