Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning:
Call of 'task.RegisterScheduleTask' copies the lock value: type 'task.ScheduleTask' contains 'atomic.Bool' contains 'interface{}' which is 'sync.Locker'
This warning is a result of Go’s strict handling of types containing atomic fields or synchronization primitives (e.g., sync.Locker). When such types are copied, it can cause subtle bugs because the copied value shares access to underlying synchronization mechanisms or memory.
This pull request includes changes to the
core/task/task.go
file to improve the handling of theisTaskRunning
field in task structures. The changes ensure thatisTaskRunning
is properly initialized as a pointer to anatomic.Bool
.Initialization improvements:
core/task/task.go
: Added initialization ofisTaskRunning
as a pointer to anatomic.Bool
in theregisterTransientTask
function.core/task/task.go
: Changed theisTaskRunning
field in theScheduleTask
struct to be a pointer to anatomic.Bool
instead of a directatomic.Bool
instance.core/task/task.go
: Added initialization ofisTaskRunning
as a pointer to anatomic.Bool
in theRegisterScheduleTask
function.