Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve native additional build args handling #26

Open
galderz opened this issue Aug 21, 2020 · 2 comments · May be fixed by #39
Open

Improve native additional build args handling #26

galderz opened this issue Aug 21, 2020 · 2 comments · May be fixed by #39

Comments

@galderz
Copy link
Member

galderz commented Aug 21, 2020

When building native images, it's quite common to pass in additional parameters, e.g.

 -Dquarkus.native.additional-build-args=--report-unsupported-elements-at-runtime,-H:+PrintAnalysisCallTree

server-runner pom.xml defines a set of fixed additionalBuildArgs in the pom.xml, which means the ones passed in via command line are ignored. server-runner pom.xml should, if possible, bring those in and add to them if necessary.
@galderz
Copy link
Member Author

galderz commented Oct 14, 2020

Quarkus maven plugin prints this now:

[WARNING] Your application is setting the deprecated 'additionalBuildArgs' Maven option. This option overrides any value passed to the 'quarkus.native.additional-build-args' property and will be removed in the future. Please consider using 'quarkus.native.additional-build-args' instead of 'additionalBuildArgs'.

So I'm removing additionalBuildArgs for now.

@galderz
Copy link
Member Author

galderz commented Oct 14, 2020

I don't know how to handle this best, I guess I'll keep a master snapshot branch without this parameter for now... :\

galderz added a commit to galderz/infinispan-quarkus that referenced this issue Nov 4, 2020
@galderz
Add a native profile with no build args infinispan#26
bdef747 
* A workaround to keep `mvn ... -Dnative` working as expected,
while it easily offers a way to build native passing in
-Dquarkus.native.additional-build-args via command line.
* Additional build args via command line can help pass in
diverse debugging and profiling options.
@galderz galderz linked a pull request Nov 4, 2020 that will close this issue
Open
galderz added a commit to galderz/infinispan-quarkus that referenced this issue Nov 5, 2020
@galderz
Add a native profile with no build args infinispan#26
2021dcc 
* A workaround to keep `mvn ... -Dnative` working as expected,
while it easily offers a way to build native passing in
-Dquarkus.native.additional-build-args via command line.
* Additional build args via command line can help pass in
diverse debugging and profiling options.
galderz added a commit to galderz/infinispan-quarkus that referenced this issue Nov 5, 2020
@galderz
Add a native profile with no build args infinispan#26
53ec46a 
* A workaround to keep `mvn ... -Dnative` working as expected,
while it easily offers a way to build native passing in
-Dquarkus.native.additional-build-args via command line.
* Additional build args via command line can help pass in
diverse debugging and profiling options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for native profiles and java invocations galderz/infinispan-quarkus
1 participant
@galderz