Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react native #56

Merged
merged 8 commits into from
Jan 4, 2019
Merged

Upgrade react native #56

merged 8 commits into from
Jan 4, 2019

Conversation

robinheinze
Copy link
Member

@robinheinze robinheinze commented Jan 4, 2019

I used react-native-git-upgrade to upgrade to 0.57.8, then the rest of the changes were to get the app running on both platforms, as well as a Typescript upgrade.

Changes

NOTE: There is currently an issue with running the app in Storybook mode due to the Metro changes with 57. The storyshot snapshots tests are running okay, but I'll have to look into potentially upgrading Storybook to 4.0 to get them to run in-app, unless someone else has come across a solution.

Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a quick perusal, nothing stood out as a problem to me. One minor nit near the end.

Copy link
Member

@GantMan GantMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no red flags! Looks good to me

@robinheinze robinheinze merged commit 5aeb292 into master Jan 4, 2019
@robinheinze robinheinze deleted the upgrade-react-native branch January 4, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants