Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inflection Support #289

Merged
merged 3 commits into from
Dec 12, 2017
Merged

Inflection Support #289

merged 3 commits into from
Dec 12, 2017

Conversation

ryanlntn
Copy link
Member

This PR adds pluralize as a dependency and exposes it's functions under string utils. Adding the following functions:

plural
singular
addPluralRule
addSingularRule
addIrregularRule
addUncountableRule
isPlural
isSingular

skellock
skellock approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@skellock skellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: Plural of regex.

Code looks good... would you be able to update the docs & typescript typings as well? <3

@ryanlntn
Copy link
Member Author

Yeah sure thing.

@skellock
Copy link
Contributor

Sweet! Thanks!

@ryanlntn
Copy link
Member Author

btw @skellock the plural of regex is regexen: https://en.wiktionary.org/wiki/regex

Should I fix?

@jamonholmgren jamonholmgren merged commit d4d5149 into master Dec 12, 2017
@jamonholmgren jamonholmgren deleted the feature/inflection branch December 12, 2017 23:59
@jamonholmgren
Copy link
Member

Excellent. We should update the readme too; I'm happy to do that before releasing.

@GantMan GantMan mentioned this pull request Dec 13, 2017
Merged
@infinitered-circleci
Copy link

🎉 This PR is included in version 0.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skellock skellock skellock approved these changes

@jamonholmgren jamonholmgren jamonholmgren approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
2.0.0-alpha.17
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanlntn @skellock @jamonholmgren @infinitered-circleci