Improves startup speed and displays duration after installing. #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skellock
approved these changes
May 5, 2017
| @@ -34,7 +34,10 @@ function attach (plugin, command, context) { | |||
| const reactNativeVersion = opts.version || parameters.options['react-native-version'] || REACT_NATIVE_VERSION | |||
| const reactNativeTemplate = opts.template || parameters.options['react-native-template'] | |||
|
|
|||
| const perfStart = (new Date()).getTime() | |||
There was a problem hiding this comment.
Would be nice to have this feature in gluegun. infinitered/gluegun#197
| @@ -61,10 +64,11 @@ function attach (plugin, command, context) { | |||
| log('initializing react native') | |||
| log(cmd) | |||
| const withTemplate = reactNativeTemplate ? ` with ${print.colors.cyan(reactNativeTemplate)} template` : '' | |||
| const spinner = print.spin(`adding ${print.colors.cyan('React Native ' + reactNativeVersion)}${withTemplate} ${print.colors.muted('(60 seconds-ish)')}`) | |||
| const spinner = print.spin(`adding ${print.colors.cyan('React Native ' + reactNativeVersion)}${withTemplate} ${print.colors.muted('(30 seconds-ish)')}`) | |||
skellock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
• Shaves about 2-3 seconds off of startup time by avoiding costly and probably over-cautious checks
• Adds some perf numbers to the output:
I spent a lot of time pouring through the code here. There's not a lot of additional optimizations that I could find that made a large difference. Most of the improvements came from the boilerplate.