Fixes some generated boilerplate issues #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
commented
May 6, 2017
| @@ -33,7 +34,7 @@ async function install (context) { | |||
|
|
|||
| // attempt to install React Native or die trying | |||
| // this will also chdir into the new directory | |||
| const rnInstall = await reactNative.install({ name, skipJest: true }) | |||
| const rnInstall = await reactNative.install({ name, version: REACT_NATIVE_VERSION }) | |||
There was a problem hiding this comment.
Pass in RN version here, don't skip Jest tests.
jamonholmgren
commented
May 6, 2017
| @@ -80,7 +81,7 @@ async function install (context) { | |||
| // pass along the debug flag if we're running in that mode | |||
| const debugFlag = parameters.options.debug ? '--debug' : '' | |||
|
|
|||
| await system.spawn(`ignite add <%= props.pluginName %> ${debugFlag}`, { stdio: 'inherit' }) | |||
| await system.spawn(`ignite add ${__dirname} ${debugFlag}`, { stdio: 'inherit' }) | |||
There was a problem hiding this comment.
Important change here -- otherwise, can't test boilerplate from path.
jamonholmgren
commented
May 6, 2017
| @@ -16,5 +16,5 @@ | |||
| import { AppRegistry } from 'react-native' | |||
| import App from './App/App.js' | |||
|
|
|||
| AppRegistry.registerComponent('<%= props.name %>', () => App) | |||
| AppRegistry.registerComponent('<%- '<' + '%= props.name %' + '>' %>', () => App) | |||
There was a problem hiding this comment.
Need to retain the <%= props.name %> after we generate this, so have to break it up like this.
skellock
approved these changes
May 6, 2017
|
Jamon, you're doing awesome work! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.