Shows a warning when adding a version-less plugin from a path.

[jamonholmgren]

Fixes #1006.

[skellock]

I'm:

• 👍 on the plugin changes
• 👎 on the warning
• 👎 on the--yolo option

Strawman-mode Engage!

So, run this: react-native init FunTown

See that yellow warning in the middle?

As a person building a new React Native project, that's meaningless.

Here's the same thing with create-react-app:

So, if I was given the power to --yolo my way thru it, I'd never do it. It would never fix anything.

What I need is for upstream to fix their stuff. I don't even know how far upstream either.

Jump To Conclusions Mat

And, so this is what this PR is bringing to the table, forcing info on end-users where no action can be taken.

Recommendations

• Keep the plugin.js.ejs changes. As plugin & boilerplate authors, it's on us to responsibly install our dependencies.

• Drop the --yolo enforcement.

I could be convinced (or at least be upgraded to 😐 ) to keep the warning (if the wording was more along the lines of

Dearest innocent bystander,

Go to {repo} and file an issue with {ignite-plugin} to tell them to add {version} to their addModule({dependency}) like we recommend in {link to docs}.

-- ignite team

[jamonholmgren]

I'm all with you on this, @skellock, makes sense.

I thought you were for the warning, though...?

[skellock]

I thought i was too.

[GantMan]

dem multiple returns :)

@skellock knows my skin crawled just now.

[jamonholmgren]

Okay, okay, I'll change it. 🙄

Sidenote: I like multiple returns -- short circuit the rest of the function if it's not necessary, like a guard statement.

But I'm not dogmatic about it. I don't want your skin crawling. 😁

[GantMan]

I think we're saying "warning" so we can do a deprecation phase. I'm fine if it says what @skellock says, but we need something to identify it's not ok... other than just forcing it.

Or maybe we just force it?

[jamonholmgren]

I'm solving the problem by only outputting the warning if we're adding the plugin from a path, like a plugin author might.

[GantMan]

very nice

[skellock]

That's a good compromise. Thank you.