Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Generators | Base ] - Listview grid #175

Merged
merged 9 commits into from
Jun 20, 2016
Merged

[Generators | Base ] - Listview grid #175

merged 9 commits into from
Jun 20, 2016

Conversation

GantMan
Copy link
Member

@GantMan GantMan commented Jun 19, 2016

Ignite Base Change

  • Works on iOS/Android/XDE
  • Tests Pass (run: npm run test)
  • Code is StandardJS compliant (run: npm run lint)

Generator Change

  • package.json lists all generators under "files"
  • I have run and tested npm compile with latest src

listview

Adds grid as requested in #164

@GantMan
Copy link
Member Author

GantMan commented Jun 19, 2016

ALSO:

I updated every generator to the latest method for NamedBase.

@GantMan
Copy link
Member Author

GantMan commented Jun 19, 2016

listngrid

@GantMan
Copy link
Member Author

GantMan commented Jun 19, 2016

@justinhuskey - I guess these could look better. Thoughts?

@GantMan GantMan merged commit c4f3427 into master Jun 20, 2016
@GantMan GantMan deleted the listview_grid branch June 20, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GantMan