-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expo SDK 48, react-native 0.71.7 #2377
Conversation
@frankcalise in the actual version of detox 19.12.1 , in the package json , we seethe the version of jest in the peer dependencies is less Than 28, I think upgrading detox is the solution to use jest 29 and to fix the pipeline |
Small typo in the issue title - says 72.3 not 71.3 |
@frankcalise Expo fixed the yarn upgrade expo
npx expo install --fix |
Thanks will take a look!! |
Have you run into this error lately?
|
I did encounter that but can't remember which library it was, can you share the stacktrace or console log? There should be a hint of who's using |
@frankcalise Ok I remembered now, it was an issue with react-navigation. If you update it should not throw that error. For reference I think it was fixed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to some pairing with @frankcalise, we got the tests figured out.
- Newest version of
jest-runner
can't handle processing itself, so we needed to ignore it - Some of the generator templates were out of date
- Updating some of the android folder files broke how we rename the app identifier. Updated now
I've tested the changes on:
- iOS
- Android
- Expo iOS
- Expo Android
- Expo Web
And this is ready to ship!
This is now live for use under |
# [8.8.0](v8.7.0...v8.8.0) (2023-05-04) ### Features * Expo SDK 48, react-native 0.71.7 ([#2377](#2377)) ([4238b32](4238b32))
🎉 This PR is included in version 8.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn test
jest tests pass with new tests, if relevantREADME.md
has been updated with your changes, if relevantDescribe your PR
Upgrades Ignite to
Expo SDK 48
andReact Native 0.71.7