feat: Add yarn to install packages #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if yarn is installed and use it instead of npm to install packages in ignite-generator.
kevinvangelder
approved these changes
Oct 27, 2016
| commandOpts.push('install') | ||
| this.log(`\n➟ Package manager:\t[ ]︎ npm | [${check}]︎ yarn`) | ||
| } | ||
|
|
||
| // run the npm command |
There was a problem hiding this comment.
Nit-picky, but could you change this comment to Install node modules?
GantMan
approved these changes
Oct 28, 2016
| } else { | ||
| command = 'yarn' | ||
| commandOpts.push('install') | ||
| this.log(`\n➟ Package manager:\t[ ]︎ npm | [${check}]︎ yarn`) |
| this.log(`\n➟ Package manager:\t[${check}]︎ npm | [ ]︎ yarn`) | ||
| } else { | ||
| command = 'yarn' | ||
| commandOpts.push('install') |
There was a problem hiding this comment.
yarn doesn't need install, but I see why you added it.
| let commandOpts = [] | ||
|
|
||
| // Use Yarn if it is installed | ||
| if (!Shell.which('yarn')) { |
There was a problem hiding this comment.
in the future I always found if (trueCondition) true else false condition more readable than if (not true) false else true condition
I know that's a nit, but if Ruby programming taught me anything, it's that removing inversions like that increases readability speed more than I ever thought it would.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
ignite-baseava tests passfireDrill.shpassedDescribe your PR
Check if yarn is installed and use it instead of npm to install packages
in ignite-generator.
Everything works on iOS/Android
Only checked the iOS app and everything works.
fireDrill.sh output