Add Search Bar to CustomNavBar #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
October 30, 2016 21:21
|
Any chance you could rebase this? It's hard to see what's changed. |
|
LGTM 👍 Do you think we should do a generator for this option? |
skellock
approved these changes
Nov 9, 2016
| storeConfig: { | ||
| storage: AsyncStorage, | ||
| blacklist: ['login'], // reducer keys that you do NOT want stored to persistence here | ||
| blacklist: ['login', 'search'], // reducer keys that you do NOT want stored to persistence here |
There was a problem hiding this comment.
I'm thinking we should switch to preferring whitelist. Not relevant to this PR, but just thinking outloud.
There was a problem hiding this comment.
I generally prefer blacklisting in most apps. We should discuss.
|
|
||
| // Used for friendly AlertMessage | ||
| // returns true if the dataSource is empty | ||
| _noRowData () { |
There was a problem hiding this comment.
I'm not a fan of _. :( Again, just general bitching. Nothing really do with this PR. Hah... oh boy. I'm annoying myself now.
There was a problem hiding this comment.
how should we indicate private methods? If you have a better way, I'm in.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Search Bar & more functionality to the
CustomNavBaras well as a way to search a ListView(Also a few refactors & cleanups)
Please verify the following:
ignite-baseava tests passfireDrill.shpassedDescribe your PR
iOS
Android