Remove generated jest tests for now. Fixes #484 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GantMan
requested changes
Nov 22, 2016
| } else { | ||
| Shell.exec('rm -rf ./__tests__') | ||
| } | ||
| Shell.cd('../..') |
There was a problem hiding this comment.
looks good. I'd prefer we simply do something like
Shell.rm('-rf', `${projectFolder}/__tests__`)2 nitpicks for this: Firstly, ShellJS remove command is already platform universal, so no need to regex, it'll just work. Second, I think you're cding into the wrong folder on line 48. Copypasta right?
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
ignite-baseava tests passfireDrill.shpassedDescribe your PR
Still need to verify that this works @GantMan. Can't remember how to test the generators locally.