Missing dev dependency on 'standard' command #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git commits would fail with no standard command as it wasn't getting installed on project init.
GantMan
reviewed
Nov 26, 2016
| @@ -62,7 +62,8 @@ | |||
| "reactotron-redux": "^1.5.2", | |||
| "reactotron-redux-saga": "^1.5.2", | |||
| "snazzy": "^5.0.0", | |||
| "standard-flow": "^1.0.0" | |||
| "standard-flow": "^1.0.0", | |||
There was a problem hiding this comment.
Ignite default app gave me:
$ git commit -a -m "i like turtles"
> exampleapp@0.0.1 lint /Users/mike/Code/exampleapp
> standard --verbose | snazzy
sh: standard: command not found
I couldn't commit anything to Git until I installed 'standard'.
|
So no errors in the CI - other than ones outside this patches control regarding fsevents. |
|
go ahead and merge master in for the CI, should be a button on github below this messsage. |
|
@GantMan "Only those with write access to this repository can merge pull requests." is all I can see. |
|
thanks @budda! Welcome to the Ignite Contributor's list! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
ignite-baseava tests passfireDrill.shpassedDescribe your PR
Git commits would fail with no standard command as it wasn't getting installed on project init.