Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TemperatureSagaTest #517

Merged

Conversation

derekgreenberg
Copy link
Member

@derekgreenberg derekgreenberg commented Nov 30, 2016

Please verify the following:

  • Everything works on iOS/Android
  • ignite-base ava tests pass
  • fireDrill.sh passed

Describe your PR

@GantMan
Copy link
Member

GantMan commented Nov 30, 2016

nice, thanks!

@GantMan GantMan merged commit 0ec7e0e into infinitered:master Nov 30, 2016
@derekgreenberg
Copy link
Member Author

Small improvement to the TemperatureSagaTest's 'success path' test - rather than hard-code the expected temp value that is passed to the success path test, get the calculated temperature from the convertFromKelvin transform for comparison in the t.deepEqual() step. We already have unit tests for the transform, so we should use it to generate the expected value that is passed to the reducer in this test. This ensures that changes to the FixtureApi will not break this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants