Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for React Native templates. #731

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Conversation

skellock
Copy link
Contributor

Closes #730.

ignite new SweetBabyJesus \
  --empty \
  --react-native-version 0.42.0-rc.3 \
  --react-native-template navigation

This was quick & dirty, but it'd be nice to integrate at a deeper level.

For example, I'd like to explore embracing their templates as being the blessed way to do our app templates. It's kinda awkward having both.

image

image

Their fallback of checking react-native-template-* on npm is 💯 (see facebook/react-native#12548).

@skellock skellock added the 2.0 label Feb 23, 2017
@skellock skellock added this to the 2.0 milestone Feb 23, 2017
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and I agree, let's work on using their templates if we can.

@skellock skellock merged commit e1cfd28 into master Feb 24, 2017
@skellock skellock deleted the react-native-templates branch February 24, 2017 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants