Enforces global dependencies are available. #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 2 global dependencies.
react-native-cliis required and needs to be>=2.0.0. Older versions of this cause anENOENTerror when usingnvm. So we now enforce this.yarnis optional and if installed needs to be>=0.21.0.Heads up @jamonholmgren, i removed the auto-installing of the
react-native-cliin favour of a message. We don't want to install global dependencies because we don't know the environment. The only requirement is that it is installed, not that it is installed vianpm i -g.A good example of this is when people installed on linux and they
sudo. Our command will fail, so it's better to just show them the command and let them run it.I understand this is a step back from what you had, but this is safe.
Fixes #919